Closed oxguy3 closed 5 years ago
Please update your pull request so that you try to merge to develop
branch.
And fix the conflict.
Thanks.
Any thought about my last comment, @oxguy3?
@oxguy3 I'll be pleased to merge your pull request, if there was no conflicts.
Could you please update your pull request so that you try to merge to develop
branch? Thanks.
Your pull request is quite old (mainly my fault) and most of its content is already in the branch feature/mimetypes. Can you please check it to see if you wan to add anything?
I've added 3 of the four icons (I did not add the flash icon as I believe it is not useful anymore, as flash has disappeared from the web).
I have also changed the way file support is added (media type instead of file extension). That's why I think the content of your pull request cannot be merged now. Hence I will close it.
Thanks for contributing and do not hesitate to answer here or in the feature/mimetypes pull request.
This PR adds supports for a ton of additional file extensions and four new icons (from the same Faenza icon set that the existing icons come from). This PR is a lot of small additions, but some of the major additions: