oupala / apaxy

a simple, customisable theme for your apache directory listing
https://oupala.github.io/apaxy/
GNU General Public License v3.0
1.86k stars 256 forks source link

Can't change <title> without using +SuppressHTMLPreamble which breaks style #97

Closed alexfoxetech closed 6 years ago

alexfoxetech commented 6 years ago

As above, I believe +SuppressHTMLPreamble prevents some of the HTML that apaxy extends from being generated in the first place meaning the page does not render correctly at all, are there plans to update apaxy to not be reliant on the default html so we can change the tags?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/oupala"><img src="https://avatars.githubusercontent.com/u/13458743?v=4" />oupala</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>I did not understood your issue. Could you please explain it once again?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexfoxetech"><img src="https://avatars.githubusercontent.com/u/30657237?v=4" />alexfoxetech</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Basically I want to change the <title> value of the directory. If I add a <title> to header.html it doesn't work as it actually appears in the body of the document. I cannot use IndexHeadInsert as this just appends another <title> to the header.. Is there anyway to change the title in apaxy?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/oupala"><img src="https://avatars.githubusercontent.com/u/13458743?v=4" />oupala</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>I tested to reproduce your problem, and I can't see any easy way to achieve what you want to.</p> <p>As you said, adding the <code>title</code> tag to <code>header.html</code> adds it in the body.</p> <p>Using the <code>IndexHeadInsert</code> directive just appends another <code>title</code> tag to the header, which is ignored by the browser as it is the second <code>title</code> tag.</p> <p>Maybe you can report in <code>header.html</code> the beginning of the default header that you remove when you use the <code>SuppressHTMLPreamble</code> directive.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexfoxetech"><img src="https://avatars.githubusercontent.com/u/30657237?v=4" />alexfoxetech</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Yes this is what I originally did, but using SuppressHTMLPreamble seems to break Apaxy in my tests.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/alexfoxetech"><img src="https://avatars.githubusercontent.com/u/30657237?v=4" />alexfoxetech</a> commented <strong> 6 years ago</strong> </div> <div class="markdown-body"> <p>Ok, no problem, I wasn't closing the correct tags in the footer.html file. All sorted, thank you :)</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>