oursky / likedao

Apache License 2.0
1 stars 4 forks source link

Prepare info for common customization and deployment #255

Closed mitchellchou closed 2 years ago

mitchellchou commented 2 years ago

To enable other chain to deploy doa for their use, we will need following info in more explicitly manner to make other life easier

rickmak commented 2 years ago

I tried to kick off a local dev and have following road block:

I try to redo the setup using likecoin-public-testnet-5 for bdjuno and it keep complaining with ERROR: failed to start client: websocket: bad handshake

@hochiw what you think we should do to fix it before asking people to use it.

hochiw commented 2 years ago

bad handshake seems like wrong rpc/grpc endpoint to me, but regardless if the db already has information from another chain it has to be wiped first before getting data from other chain in. I can see if we can add such feature to the bdjuno makefile.

As for the environment alignment do we scrap the default values and let users key in their chain config before they could use the app? or do we use mainnet?

hochiw commented 2 years ago

Current testnet bdjuno config

        rpc:
            client_name: juno
            address: http://likecoin-public-testnet-5.oursky.dev:26657
            max_connections: 20
        grpc:
            address: likecoin-public-testnet-5.oursky.dev:9090
            insecure: true
hochiw commented 2 years ago

@rickmak sorry got distracted, did we say we want to let the user key in everything themselves instead of giving a default?

So the current actionable is

  1. Review and improve README
  2. Add deployment documentation oursky/likedao#39
  3. Align default values
  4. Improve UI theming
rickmak commented 2 years ago

Review and improve README

This is not actionable. Let's be more specific.

My comment lead to Align default values or requires to specific target chain.

Improve UI theming I think we should already have UI theming? Just some document should be okay.

hochiw commented 2 years ago

This is not actionable. Let's be more specific.

My comment lead to Align default values or requires to specific target chain.

For stability I think we should target mainnet, so the GENESIS_URL will point to the json file in mainnet repo by default.

I shall add a section in the root README regarding this information as well as other necessary configuration for the services to raise attention to customization of the app, targeting the config.js file for react-app, config.yaml for bdjuno and .env for the gql server.

I think we should already have UI theming? Just some document should be okay.

i think we mistakenly followed the color names from the design so now that color names we are using have a likecoin prefix.

rickmak commented 2 years ago

Thanks, I can see there is 3 actionable to work on.