ourzora / zora-protocol

Monorepo for Zora Protocol (contracts & sdks)
MIT License
113 stars 70 forks source link

`baseSepolia` support in `@zoralabs/protocol-deployments` #415

Closed SweetmanTech closed 3 months ago

SweetmanTech commented 3 months ago

request:

I believe the following info should be added to the addresses export

usage:

import { contracts1155 } from '@zoralabs/protocol-deployments';

const collectionAddress = contracts1155.addresses[baseSepolia.id],

error:

Property '84532' does not exist on type '{ "1": { CONTRACT_1155_IMPL: string; CONTRACT_1155_IMPL_VERSION: string; FACTORY_IMPL: string; FACTORY_PROXY: string; FIXED_PRICE_SALE_STRATEGY: string; MERKLE_MINT_SALE_STRATEGY: string; ... 5 more ...; timestamp: number; }; ... 9 more ...; "999999999": { ...; }; }'. Did you mean '8453'?
Screenshot 2024-06-09 at 7 01 52 AM
SweetmanTech commented 3 months ago

pull request to fix the issue: https://github.com/ourzora/zora-protocol/pull/416

oveddan commented 3 months ago

hey @SweetmanTech thanks for the PR - that addresses.ts file is legacy and shouldn't have been bundled - we actually are already bundling base sepolia addresses in contracts1155:

import {
  contracts1155
} from "@zoralabs/protocol-deployments";

const baseAddresses = contracts1155.addresses[baseSepolia.id];

we should actually just delete addresses.ts to avoid confusion

see the script https://github.com/ourzora/zora-protocol/blob/main/packages/protocol-deployments/scripts/bundle-configs.ts to see how the addresses are autobundled (we gitignore it)