outerbounds / terraform-aws-metaflow

Deploy production-grade Metaflow cloud infrastructure on AWS
https://registry.terraform.io/modules/outerbounds/metaflow/aws/latest
Apache License 2.0
58 stars 50 forks source link

API Gateway should be optional #22

Open olivermeyer opened 2 years ago

olivermeyer commented 2 years ago

The API Gateway is only useful when external traffic is expected. In cases where all traffic will be internal to the VPC in which Metaflow is hosted, the API Gateway only adds value if it's used for additional access control. It's also a liability because the only way to deny all incoming traffic is to misuse the access_list_cidr_blocks variable to make the API Gateway's resource policy allow traffic only from an impossible IP range.

I see two solutions here:

I think the first solution is preferable in the long run, but the second is simpler to implement. I'm happy to open a PR but I'm not sure which way to go.

benchoncy commented 2 years ago

I'm also in a situation where the API gateway goes unused; it would be nice to see this be optional.

PierceCoggins commented 2 years ago

Agree with this - we could really use optional API gateway too