Enable some variables to be externally provided to the computation module - Githubissues

outerbounds / terraform-aws-metaflow

Deploy production-grade Metaflow cloud infrastructure on AWS

https://registry.terraform.io/modules/outerbounds/metaflow/aws/latest

Apache License 2.0

56 stars 48 forks source link

Enable some variables to be externally provided to the computation module #58

Closed benchoncy closed 1 year ago

benchoncy commented 1 year ago

Enables the below variables to be provided externally to the computation module. All default to keep existing functionality.

compute_environment_allocation_strategy, Allows alternative allocation strategies which may be better suited depending on the use case, e.g. SPOT_CAPACITY_OPTIMIZED for spot environments.
compute_environment_additional_security_group_ids (#52)
launch_template_image_id, allows for custom AMIs to be provided.

No data from data.tf appeared to be used anywhere in the module. So I also removed this file.

benchoncy commented 1 year ago

lgtm! sorry it took a while to get to it

No problem, thanks @oavdeev!