search

outscale / osc-bsu-csi-driver

Apache License 2.0
8 stars 18 forks source link

add support for multiple feature-gates arguments for the csi-provisioner #810

Closed yacinebbt closed 2 months ago

yacinebbt commented 5 months ago

Is this a bug fix or adding new feature? It can be a bug fix or a new feature, it's up to you to decide how to name it.

What is this PR about? / Why do we need it?

What?

When i want to enable a feature gate and specify it to be used by the provisioner, everytime i need to deploy the helm chart then edit the csi-controller deployment by adding the args needed.

        - name: csi-provisioner
          image: registry.k8s.io/sig-storage/csi-provisioner:v3.0.0
          args:
            - '--csi-address=$(ADDRESS)'
            - '--feature-gates=Topology=true'
            - '--feature-gates=Key=Value'

Why? To make it possible for users to controll which extra feature gates or extra arguments in general to enable using the helm chart, without the need of doing that manually after the deployment everytime.

What testing is done?

Simply deploy a helm chart and try to enable a feature gate of your choice automatically, you'll not find where to specify your argument.