outscale / osc-bsu-csi-driver

Apache License 2.0
8 stars 18 forks source link

Remove default value for imagePullSecrets #811

Closed albundy83 closed 2 months ago

albundy83 commented 4 months ago

/kind bug Hello,

can you remove the default value for the imagePullSecrets which are here: https://github.com/outscale/osc-bsu-csi-driver/blob/master/osc-bsu-csi-driver/templates/node.yaml#L44 and here: https://github.com/outscale/osc-bsu-csi-driver/blob/master/osc-bsu-csi-driver/templates/controller.yaml#L47

As if we don't use it, we have Events complaining about missing Secret.

Thanks a lot :)

albundy83 commented 2 months ago

Hello,

here the repeating message from Kubernetes Events "Unable to retrieve some image pull secrets (registry-dockerconfigjson); attempting to pull the image may not succeed."

outscale-hmi commented 2 months ago

https://github.com/outscale/osc-bsu-csi-driver/pull/815 merged