search

overlayeddev / overlayed

A modern, open-source, and free voice chat overlay for Discord that supports Mac, Linux, and Windows
https://overlayed.dev
GNU Affero General Public License v3.0
357 stars 27 forks source link

Added os aware download card #188

Closed MUK-Dev closed 2 months ago

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlayed ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 3:33pm
MUK-Dev commented 3 months ago

this commit resolves #163

Pyr33x commented 3 months ago

You need to format the code you've written using pnpm format. Also, the build was unsuccessful.

MUK-Dev commented 3 months ago

Formatting was the issue. It seems.

Pyr33x commented 3 months ago

Yes, and I want @Hacksore to wait a bit more time to close the pr, cause I'm currently working on the download ui

Hacksore commented 3 months ago

@MUK-Dev currently the preview env shows Linux on iOS IMG_2553

looks like spacedrvie does a fallback on unsupported devices. IMG_2554

Pyr33x commented 3 months ago

@MUK-Dev currently the preview env shows Linux on iOS

It's same on Android tho

MUK-Dev commented 3 months ago

Ok, I'll take a look

MUK-Dev commented 3 months ago

Hi, kindly test it again. I only have a windows and android machine so I can't check on others. react-device-detect doesn't detect linux so I had to check for devices manually.

Hacksore commented 2 months ago

see https://github.com/overlayeddev/overlayed/issues/163#issuecomment-2325407163