overture-stack / ego

OAuth 2.0 authorization service that supports multiple OpenID identity providers
https://www.overture.bio/products/ego
GNU Affero General Public License v3.0
26 stars 14 forks source link

Refactor Flyway for testing #527

Open rtisma opened 3 years ago

rtisma commented 3 years ago

Currently, the initialization of flyway with testcontainers in the test context is extremely hacky and cannot be configured via the application.yml values. This is considered tech dept, and warrants a cleanup. Also, the version of flyway is old, this should also be updated.

Also, the java based migrations extend SpringJdbcMigration which is now DEPRECATED. The issue with upgrading our migrations, is that it may change the checksum. Before updating the java migrations with whatever replaces the deprecated SpringJdbcMigration, we need to make sure the checksums are not different. If the checksums change, then we need to see if there is planned removal of SpringJdbcMigration in future versions. If it is, then to prevent being locked to a certain flyway version, we will need to handle this case.

Exit criteria:

rtisma commented 3 years ago

The following ticket describes the deprecation of SpringJdbcMigration https://github.com/flyway/flyway/issues/2218

this means, we need to change the java migrations