ovh / manager

OVHcloud Control Panel
https://ovh.github.io/manager/
BSD 3-Clause "New" or "Revised" License
215 stars 98 forks source link

[manager]: use react-hook-form & validation library #13395

Open tristanwagner opened 1 month ago

tristanwagner commented 1 month ago

Have you already checked if a similar item is present on manager-components?

What do you expect from this request?

Others

Description

To have a clean way of handling forms and do data validations via schemas we would like to use in zimbra a new dependency react-hook-form along with a schema validating library for example zod, joi or yup. These are widely used and a must have for form handling and data validation with type inference etc.. Can we discuss about this ?

Where do you expect to use this?

@ovh-ux/manager-zimbra-app

Do you have mock-up?

No response

When do you expect this to be delivered?

ASAP

Additional Information

No response

aboungnaseng-ovhcloud commented 1 month ago
aboungnaseng-ovhcloud commented 1 month ago

Lets share with the team the differents packages

As I never use theses dependencies, you can share a message to the react js channel to have some user experience.

The only things we have to be careful its about the size of app and we need to have the same coding style inside the manager, to not have a lot of differences beetween react app, (more easy to review, more easy to debug ...)

tristanwagner commented 1 month ago

as I mentioned earlier I've used more or less all of these in differents projects and it's more or less the same thing, but I think zod is the most popular and used and the type inference is a very nice feature for using it with react-hook-form, yup is more on lightweight and simplicity and is also the oldest and least used of the 3, and finally joi is in between the 2.

To me I would chose between zod more features but bigger size or yup simplicity and lightweight but less features