fix: set ip_restrictions type to set on containerregistry_ip_restrict…

[mxm-tr]

…ions

Description

Changes the type of ip_restrictions in containerregistry_ip_restrictions resources and data from schema.TypeList to schema.TypeSet.

Fixes #636

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests have been added to verify that the order of the ip_restrictions does not influence the configuration and the state.

• [x] Test A: make testacc TESTARGS="-run ^.*ContainerRegistry.*$"

Test Configuration:

• Terraform version: terraform version: Terraform v1.5.6
• Existing HCL configuration you used:

terraform {
  required_providers {
    ovh = {
      source = "ovh/ovh"
      source = "terraform.local/local/ovh"
    }
  }
}

provider "ovh" {
  endpoint           = "ovh-eu"
  application_key    = "xxx"
  application_secret = "yyy"
  consumer_key       = "zzz"
}

data "ovh_cloud_project_capabilities_containerregistry_filter" "regcap" {
  service_name = "xxx"
  plan_name    = "SMALL"
  region       = "GRA"
}

resource "ovh_cloud_project_containerregistry" "registry" {
  service_name = data.ovh_cloud_project_capabilities_containerregistry_filter.regcap.service_name
  plan_id      = data.ovh_cloud_project_capabilities_containerregistry_filter.regcap.id
  region       = data.ovh_cloud_project_capabilities_containerregistry_filter.regcap.region
  name         = "mydockerregistry"
}

resource "ovh_cloud_project_containerregistry_ip_restrictions_management" "my-mgt-iprestrictions" {
  service_name = ovh_cloud_project_containerregistry.registry.service_name
  registry_id  = ovh_cloud_project_containerregistry.registry.id

  ip_restrictions = [
    {
      ip_block    = "192.168.0.1/32"
      description = "xxxxxxx"
    },
    {
      ip_block    = "192.168.0.3/32"
      description = "xxxxxxx"
    }
  ]
}

resource "ovh_cloud_project_containerregistry_ip_restrictions_registry" "my-registry-iprestrictions" {
  service_name = ovh_cloud_project_containerregistry.registry.service_name
  registry_id  = ovh_cloud_project_containerregistry.registry.id

  ip_restrictions = [
    {
      ip_block    = "192.168.0.1/32"
      description = "xxxxxxx"
    },
    {
      ip_block    = "192.168.0.4/32"
      description = "xxxxxxx"
    }
  ]
}

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings or issues
• [x] I have added acceptance tests that prove my fix is effective or that my feature works
• [x] New and existing acceptance tests pass locally with my changes
• [x] I ran successfully go mod vendor if I added or modify go.mod file

[amstuta]

@mxm-tr any news ?

[mxm-tr]

@mxm-tr any news ?

Yes, I had some questions about the comments on the review, cf the comments above