ovh / terraform-provider-ovh

Terraform OVH provider
https://registry.terraform.io/providers/ovh/ovh/latest/docs
Mozilla Public License 2.0
182 stars 133 forks source link

[FEATURE] Missing "description" argument in ovh_dedicated_nasha_partition_access #677

Closed 131 closed 1 month ago

131 commented 1 month ago

Description

Looking up multiple IP in ovh_dedicated_nasha_partition_access is tedious (when using the manager) hence the "description" that might be used as a hint on the server name.

Yet, this argument cannot be managed by the terraform provider. If this is a quick adjustment, this is a big improvement for us

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "ovh_dedicated_nasha_partition_access" "main" {
  for_each = var.allowed_ips

  service_name   = ovh_dedicated_nasha_partition.main.service_name
  partition_name = ovh_dedicated_nasha_partition.main.name
  ip             = each.value
  //description    = "tf-{each.key}-rw"

  type = "readwrite"
}
amstuta commented 1 month ago

Hello @131 , indeed I see that the field aclDescription is available in the API but missing in the TF resource. We'll add it quickly.

131 commented 1 month ago

Wow. Thanks

131 commented 1 month ago

hmm, updating, the acl_description result in a resource being destroy rather than updated. Seems a bit aggressive , is it possible to change that ?

amstuta commented 1 month ago

In fact, we don't have any other choice here since no route exists on the API to update an existing ACL, so have to recreate it when updating the description.