Make fits lvl1.6 - Githubissues

ovro-eovsa / ovro-lwa-solar

Calibration, imaging, and analysis of solar data taken by the Owens Valley Long Wavelength Array (OVRO-LWA)

MIT License

5 stars 6 forks source link

Closed peijin94 closed 8 months ago

peijin94 commented 8 months ago

Level 1.5, write correction info to the file but do not apply the shift. need to do "apply shift" in the plot function

fig = vis.slow_pipeline_default_plot(fname1_5, apply_refraction_corr=True)

Level 1.6, applied shift to data array CRVAL1 and CRVAL2 are 0, CPIX1 and CPIX2 are datashape//2. more generic, no need to apply correction

fig = vis.slow_pipeline_default_plot(fname1_6, apply_refraction_corr=False)

binchensun commented 8 months ago

The changes look good. Please see my other suggestions at https://github.com/ovro-eovsa/ovro-lwa-solar/issues/55

refraction_fit_param() needs to return px, py, as well as a timestamp. The entire array of corrections is unnecessary and is dependent on the exact frequency structure of the FITS file. When applying the refraction corrections to a FITS file, we can take these coefficients, timestamp, and frequency information to calculate new arrays and apply them.