search

owasp-modsecurity / ModSecurity

ModSecurity is an open source, cross platform web application firewall (WAF) engine for Apache, IIS and Nginx. It has a robust event-based programming language which provides protection from a range of attacks against web applications and allows for HTTP traffic monitoring, logging and real-time analysis.
https://www.modsecurity.org
Apache License 2.0
8.31k stars 1.61k forks source link

Add regression rules for test #3291

Closed hnakamur closed 3 weeks ago

hnakamur commented 4 weeks ago

what

Add a regression rule for test copied from:

why

Because these two files are needed for regeression tests to pass before merging Fix modsecurity-regression-test-secremoterules.txt URL in example by hnakamur · Pull Request #3287 · owasp-modsecurity/ModSecurity.

references

https://github.com/owasp-modsecurity/ModSecurity/pull/3287#issuecomment-2450272685

airween commented 3 weeks ago

Hi @hnakamur,

I'm afraid you put this file to a wrong place. It's under to root directory, not under the test as you referred in the test file.

Probably it would be better under test/test-cases/data. Or may be you can use any existing one, eg this (if it fits with your expectation).

hnakamur commented 3 weeks ago

@airween Oh sorry. I fixed it at https://github.com/owasp-modsecurity/ModSecurity/pull/3291/commits/742f97ccc03daac6978d65bfe7e384e3425783b0

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud