search

owen2345 / camaleon-cms

Camaleon CMS is a dynamic and advanced content management system based on Ruby on Rails
https://camaleon.website
MIT License
1.22k stars 287 forks source link

Feature/support custom aws endpoint #1101

Closed graysonchen closed 1 month ago

graysonchen commented 1 month ago

hey @texpert is it ready to merge it? @owen2345 Thank you feedback.

texpert commented 1 month ago

hey @texpert is it ready to merge it? @owen2345 Thank you feedback.

@graysonchen, not yet ready to merge - there is a lint failure, and also, a failure of the rails_edge version. Can you fix them? Otherwise, I'll work on them when I will have some time - hopefully, next weekend.

texpert commented 1 month ago

OK, I've fixed the Rubocop issue, and the remaining failure is caused by font-awesome-rails and non-digest-assets not yet supporting the Rails 8 version. So, merging it!

Thanks again, @graysonchen!