search

owmii / Powah

Discord:
https://discord.gg/A8TP9JY
GNU Lesser General Public License v3.0
28 stars 22 forks source link

Fix #150 CME in client setup event #154

Closed BlueAgent closed 3 years ago

BlueAgent commented 3 years ago

Depends on https://github.com/owmii/Lollipop/pull/13

Fix #150 by using event.enqueueWork for things that are not thread safe. Was happening because the FMLClientSetupEvent is run in parallel so it's unsafe to call methods that for example insert into a HashMap.

Not sure if you wanted to add something to Lollipop to generalize this fix but this should be okay for now. Made a PR to Lollipop to add in a method for synchronous setup. Will make a similar PR to LostTrinkets.

Hope I'm not bothering too much with these PRs. Feel free to take your time with releases, no rush okay? Want you to be well. ❤️

owmii commented 3 years ago

Thank you so much!!, I really appreciate your helping me.