owncloud / music

:notes: Music app for ownCloud
GNU Affero General Public License v3.0
562 stars 197 forks source link

Aif Aiff format support #767

Closed astrocycles closed 1 year ago

astrocycles commented 4 years ago

Hi, Are you planing to add full quality player : Aiff, Aif ?

thanks

paulijar commented 4 years ago

There are no such plans at the moment. It seems to me, that neither Firefox, Chrome, nor Edge support playing the aiff format. With a quick lookup, I could not find any javascript libraries either which would enable the aiff playback so this looks like a dead-end.

Based on someone's comment, apparently the Safari browser would support playing aiff files. However, I can't verify this claim as Safari is nowadays Mac-only.

If the browser-side support for this format ever becomes available in the main-stream PC browsers, then adding the support also to the Music app should be a no-brainer. Until then, there's no chance.

astrocycles commented 4 years ago

Hi,

Thanks for your prompt reply. Le 7 juin 2020 à 16:47 +0200, Pauli Järvinen notifications@github.com, a écrit :

There are no such plans at the moment. It seems to me, that neither Firefox, Chrome, nor Edge support playing the aiff format. With a quick lookup, I could not find any javascript libraries either which would enable the aiff playback so this looks like a dead-end. Based on someone's comment, apparently the Safari browser would support playing aiff files. However, I can't verify this claim as Safari is nowadays Mac-only. If the browser-side support for this format ever becomes available in the main-stream PC browsers, then adding the support also to the Music app should be a no-brainer. Until then, there's no chance. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

JoshuaPettus commented 4 years ago

Seeing as aiff/aif is an apple format, I would expect Saffari to support it. You use to have to use a quicktime plugin to play such files in other browsers, but I doubt that's available any more.

In the mean time, I'm pretty sure can convert your .aiff to .wav, without any data loss, as both are uncompressed audio formats. The data is just stored in a different way between the two. Wish there was a tool that could do that straight in NC

paulijar commented 1 year ago

While investigating https://github.com/owncloud/music/issues/1030, I accidentally noticed that the Aurora.js library, which we were already using, is actually able to play .aiff files without any extra plugins. Similarly, it can play .wav, .au, and .caf files. So now in Music v1.8.0, also the .aiff playback is possible even if the browser at hand has no native support. The Music app always first tries to use the native codec and uses the Aurora.js only as a fallback solution. The limitation of this fallback solution is that seeking within the song is not possible, nor is adjusting the playback speed. There's also a good chance that it will fail on some files, but at least the few sample files I could find played fine.

The gotcha is that Music app can see and play only such files which have been mapped to MIME types audio/* on your cloud instance. Neither ownCloud nor Nextcloud map the .aif/.aiff/.aifc files by default. You can automatically add those mappings with Music v1.8.0 by running

sudo -u www-data php occ music:register-mime-types

.

djtulan commented 8 months ago

Hi!

I noticed, that AIFF / AIF files are not registered anymore on a nextcloud-snap image.

I run the command on my server, and it created the correct json file: sudo nextcloud.occ music:register-mime-types

/var/snap/nextcloud/current/nextcloud/config/mimetypemapping.json

But the aiff files are not shown in my music app. All the other formats (wav, mp3, flac) work fine. nextcloud-snap version is 27.1.4 music app version 1.9.1

paulijar commented 8 months ago

@djtulan I have seen that sometimes the occ music:register-mime-types doesn't fix the mime type mappings of the existing files even though it is actually supposed to do that. I'm not certain, if this depends on the Nextcloud version or something else. However, any newly uploaded files should still get the correct mime mappings after the script has been run. So if you remove one of your aiff files and then re-upload it to your Nextcloud, then it probably should become visible in Music. It might be enough also to just reupload and rewrite the existing file, without deleting the original copy, but I don't remember for certain.

djtulan commented 8 months ago

@paulijar You are absolutly right. New uploaded files are listet now. But I have seen another Problem. And I think there is still a Problem with AIFF files:

Screenshot_20231220_091137

The title of the AIFF tag looks a bit faulty. When I open it with an ID3 editor, everything looks correct.

paulijar commented 8 months ago

@djtulan Could you share one aif file with this problem with me? You can find my email address from my GitHub profile.

djtulan commented 8 months ago

@paulijar , I sent you a DL link for the file. Hex Editor shows that bytes, if this is helpful?

Screenshot_20231220_114120

paulijar commented 8 months ago

@djtulan I opened a new issue https://github.com/owncloud/music/issues/1115 for this title problem, as that's clearly separate from the original feature requirement, and this issue is already closed anyway.