search

owncloud / ocis-charts

:chart_with_upwards_trend: Helm Charts for ownCloud's OCIS
https://owncloud.dev/ocis/deployment/kubernetes/
Apache License 2.0
49 stars 27 forks source link

Use unique names -- include release name #140

Open remram44 opened 1 year ago

remram44 commented 1 year ago

This is the first Helm Chart I've encountered that don't include the release name in the names of created object. If I helm install mycloud ocis/ocis, I expect deployments/services/... objects to be named mycloud-web, mycloud-proxy, ... so they don't conflict with other installed charts.

This is even the default in the helm create chart. Why did you get rid of the fullname macro? This is dangerous.

wkloucek commented 1 year ago

I will have a look into this. It's most likely not there because this chart was not bootstrapped by helm create.

remram44 commented 1 year ago

helm create does use unique names, via the ocis.fullname template.

It was present in the first commit and was immediately removed:

https://github.com/owncloud/ocis-charts/blob/7f91f94c9d96e20c60aaa55a35e1d213755d2fae/templates/deployment.yaml#L3-L6

d7oc commented 1 year ago

Yes was removed without further notice in ec848c1fb1c3bcc13a986a2c2dc3e1ee3e52f680. I will try to add this again.

d7oc commented 1 year ago

Had a first look. There is a dependency to https://github.com/owncloud/ocis-charts/issues/50 which needs to be addressed first. If the app/service names change, the certificate as generated in our docs at https://doc.owncloud.com/ocis/next/deployment/container/orchestration/orchestration.html#built-in-user-management-secrets won't match anymore, as the name will not be fixed to idm each time. So there needs to be a dynamic process.

dnrce commented 9 months ago

@d7oc and @wkloucek, I see that #50 is resolved. Are you aware of anything else that would still block this change?

wkloucek commented 8 months ago

@d7oc and @wkloucek, I see that #50 is resolved. Are you aware of anything else that would still block this change?

The release name would needed to be included in every objects' name. Also we would need to touch all selector labels. Also the secret auto-generation would need to be touched.

I guess it's still a lot of work (especially when considering a path for backwards compatibility). To be honest, from my side this is more a low priority right now, but I'm just a developer and no product manager.