search

owncloud / updater

GNU Affero General Public License v3.0
27 stars 19 forks source link

fix: exit with success command line status 0 for not implemented things #730

Closed phil-davis closed 9 months ago

phil-davis commented 9 months ago

PR #711 made sure to return an int command line status from all Symfony command execute functions.

But it returned 1 for commands that are not yet implemented. That causes scripts to fail if they call any of the not-yet-implemented commands. That has resulted in upgrades failing when they previously worked (albeit with some steps not implemented). Although some steps were not yet implemented, the actual upgrade was working.

This PR changes the command line status to 0 for not-yet-implemented things. 0 is success for the command line. That puts the behavior back to the way it was.

See discussion in issue #726

Also, remove phpstan ignoreErrors entries for things that are not errors, Recent versions of phpstan no longer have these false positives, so they are no longer needed in phpstan.neon - this gets phpstan passing in CI.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

phil-davis commented 9 months ago

@jvillafanez @IljaN @jnweiger if anyone is back from leave, please review.