owncloud / web-app-dicom-viewer

ownCloud Web DICOM Viewer is an extension of ownCloud Web to preview DICOM files (medical images and their corresponding metadata)
GNU Affero General Public License v3.0
3 stars 1 forks source link

Refactor tests to move the assertions into context files #41

Closed individual-it closed 7 months ago

individual-it commented 7 months ago

There are a lot of assertion in the PageObject of the e2e tests. e.g. https://github.com/owncloud/web-app-dicom-viewer/blob/main/tests/e2e/pageObjects/DicomViewer.ts#L64-L67 The assertions should be in the Context files/Step definitions. The PageObject is a representation of the page, meaning it contains everything to communicate with the page, but the assertions should not be there