search

oxc-project / oxc-resolver

Rust version of webpack/enhanced-resolve
https://oxc.rs/docs/guide/usage/resolver.html
MIT License
146 stars 21 forks source link

test: fix symlink test init on windows #307

Closed sapphi-red closed 2 weeks ago

sapphi-red commented 2 weeks ago

When calling fs::remove_file against a symlink pointing a directory on Windows, PermissionDenied error was happening. This was causing the symlink tests to pass only for the first time.

But this makes the symlink tests to fail on Windows (https://github.com/oxc-project/oxc-resolver/issues/308). 🫠 I was able to fix them. fixes #308

codspeed-hq[bot] commented 2 weeks ago

CodSpeed Performance Report

Merging #307 will not alter performance

Comparing sapphi-red:chore/fix-symlink-test-on-windows (fb2c1ea) with main (1fe94ec)

Summary

✅ 3 untouched benchmarks