Closed dancrossnyc closed 2 years ago
For trivial changes like this, I usually test on Ethanol, but given that the bulk of updated deps were on xtask
, which is a standalone binary that runs on the host, and the only dep for phbl
proper was for a dev-dep of the x86
package ("raw-cpuid"), and that we only use x86
for accessing MSRs, I reasoned the changes would be small and just dumped the disassembly and looked at it: the only differences were a couple of debug functions moving. Not changing, just moving.
Anyway, I can start it on a gimlet just to be extra-sure.
I am confident, but just because I'm paranoid doesn't mean that they are not out to get me.
Fortunately, gimlet boots as expected.
Run
cargo update
for phbl and xtask.Signed-off-by: Dan Cross cross@oxidecomputer.com