search

oxiton-foundation / click-metrics

Click Matrics is a powerful URL shortening and analytics platform designed to streamline the process of generating short URLs, creating QR codes, and tracking detailed analytics for each link.
https://click-metrics.vercel.app
MIT License
30 stars 42 forks source link

feat: Custom qr added #202

Closed RamakrushnaBiswal closed 4 months ago

RamakrushnaBiswal commented 4 months ago

Related Issue(s)

Description

Describe the purpose and scope of your pull request here. Include a brief overview of the changes introduced and any relevant context that reviewers should be aware of.

Changes Made

Provide a detailed list of the changes made in this pull request. Include specific files, components, or functionalities affected by your modifications.

Screenshots (if applicable)

image

Checklist

Before submitting your pull request, ensure that you have completed the following tasks:

Additional Notes

Add any additional information, concerns, or considerations that may be relevant to your pull request. This could include performance implications, future enhancements, or potential risks associated with the changes.

github-actions[bot] commented 4 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our #24. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

RamakrushnaBiswal commented 4 months ago

@Swarnendu0123 review the PR , i added the feature of custom QR,

Swarnendu0123 commented 4 months ago

Attach video

Swarnendu0123 commented 4 months ago

Remove the package-lock.json from client

RamakrushnaBiswal commented 4 months ago

@Swarnendu0123

https://github.com/oxiton-foundation/click-metrics/assets/125277258/a559932c-364c-498f-87c0-fb7f029db455

Swarnendu0123 commented 4 months ago

You shouldn't make an additional route. You should continue and add the functionality to the same page.

RamakrushnaBiswal commented 4 months ago

Hi @Swarnendu0123 your url generator api is different, I am using a package so I face some problem to implement that is that page that's why I create an another route

RamakrushnaBiswal commented 4 months ago

And if you want it into the same page i can make another section for that

RamakrushnaBiswal commented 4 months ago

@Swarnendu0123 review the PR

Swarnendu0123 commented 4 months ago

Hi @Swarnendu0123 your url generator api is different, I am using a package so I face some problem to implement that is that page that's why I create an another route

Please implement in the same route, you shouldn't say that you have faced problems so you have done this. If you are getting some error, resolve that. We are building a serious product. And making an extra route is not acceptable, when there is already a route that exists. Please continue over the same route. Otherwise I have to close this PR.

RamakrushnaBiswal commented 4 months ago

hi @Swarnendu0123 i fixed it can you please check

RamakrushnaBiswal commented 4 months ago

https://github.com/oxiton-foundation/click-metrics/assets/125277258/c2ca2e24-08f6-41bc-9b16-43cf8d0a9aa3

Swarnendu0123 commented 4 months ago

Thanks!

github-actions[bot] commented 4 months ago

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Swarnendu0123 commented 4 months ago

claim your certificate: https://www.oxiton.live/dashboard