search

oxwhirl / smacv2

MIT License
211 stars 32 forks source link

Question about DuplicateMapError w/benellis3/pymarl2 #22

Open euikk opened 1 year ago

euikk commented 1 year ago

Hello, firstly, thank you for the contribution about this whole simulation environment.

I wanted to integrate SMACv2 with PyMARL, and luckly found the SMACv2 version of PyMARL, PyMARL2 https://github.com/benellis3/pymarl2 (@benellis3) #

I tried using MAC OX but faced following error

File "/anaconda3/envs/smac/lib/python3.9/site-packages/pysc2/maps/lib.py", line 122, in get_maps raise DuplicateMapError("Duplicate map found: " + map_name) pysc2.maps.lib.DuplicateMapError: Duplicate map found: 3m

After I delete 2 lines as below, it seems working, but is it a good solution for this error?

https://github.com/deepmind/pysc2/blob/0df53d38c153972f1e368572ba65b1442a0fd41f/pysc2/maps/lib.py#L121 https://github.com/deepmind/pysc2/blob/0df53d38c153972f1e368572ba65b1442a0fd41f/pysc2/maps/lib.py#L122

Thank you.

andresgr96 commented 1 year ago

Hey there! How did you get PyMARL2 running with SMACv2? More precisely, I want to run algos like QMiX and VDN from the command line/ git bash using the same/similar commands as in the docs of PyMARL. I really appreciate any help you can provide!

euikk commented 1 year ago

here

https://github.com/benellis3/pymarl2 (@benellis3)

andresgr96 commented 1 year ago

Hi there! I did check that out, but my doubt remains because when I try to run pymarl2 which should run on smac2, it tries to pull StarCraftCapabilityEnvWrapper from smac but it obviously not there since that it is smacv2.

benellis3 commented 1 year ago

@andresgr96 My apologies, I believe this error happens because I renamed the imports to smacv2, but forgot to change the pymarl2 code to import smacv2. I will test this and get a fix going for it.

@euikk I believe you should be able to fix that error by deleting any duplicate maps from your maps directory. Those lines of code shouldn't need to be deleted.

andresgr96 commented 1 year ago

Thanks for your response, will be looking forward to it. Been meaning to use SMACv2 for my bachelor's thesis but for now I'm using SMACv1 because of this issue, thanks for your hard work!