Closed NazarPauk closed 5 months ago
@NazarPauk 👋
Thanks for dropping in with the issue! Our team is ready to dive into it as soon as possible! 🚀
If you would like to work on this issue, please wait for us to decide if it's ready; hang tight until we've given it the green light. The issue will be ready to work on once we remove the label.
To claim an issue that does not have the label, please leave a comment that says ".take". If you have any questions, please follow up on the issue itself.
For full info on how to contribute, please check out our contributors guide.
Let's make some magic together! ✨
Hi @NazarPauk Good job on writing your fisrt issue! 👍 I have a few suggestions on how to improve it:
Desktop (please complete the following information)
- OS: [iOS]
- Browser [Microsoft Edge]
- Version [116.0.1938.54]
Here is how the code for images looks now
refactor-media-queries
?
Please create a new branch, and name it
fix-suggest-name
Specify the "screen and" part...
Done, thank you for the suggestion!
@NazarPauk thank you for your changes. But let's also point out in the instruction that the person will need to test if the updated media queries are still working. Hint: take a look at other issues in our project to find out where and how to write this part.
Hey @NazarPauk 👋 Let's also make a minor formatting adjustment to CSS code examples to make them more precise and consistent. Please replace 'html' with 'CSS' after the triple backticks (```) to indicate that code blocks contain CSS styling. This adjustment will bring some familiar CSS styling to your code snippets, making them easier to read and work with
@naumch1k hey! indicated, thank you for the suggestion
.take
@wwily 👋 Thanks for picking up this issue! 🙌 Feel free to reach out if you need any help or have questions!
Describe the bug Two ways of writing media queries are used, which contradicts the rules for writing them specified in readme.md
To Reproduce Steps to reproduce the behavior:
blocks
folderDesktop:
Additional context Here is how the code for media queries in some files looks now:
Correct media queries should look like this:
Quick Instruction for Working on the Issue ‼️ Before checking out to a new branch, ensure you have the latest updates from the main by running
git pull
command.refactor-media-queries
This pull request resolves [#issue_number](link_to_the_issue)
. Replaceissue_number
with the actual issue number andlink_to_the_issue
with the link to the respective issue. For example: