p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

Refactor: Using two types of media queries #40

Closed NazarPauk closed 5 months ago

NazarPauk commented 6 months ago

Describe the bug Two ways of writing media queries are used, which contradicts the rules for writing them specified in readme.md

To Reproduce Steps to reproduce the behavior:

  1. Go to the blocks folder
  2. Click on the style files of the blocks and their elements
  3. You can see different usage of media queries.

Desktop:

Additional context Here is how the code for media queries in some files looks now:

@media(max-width:1199px){
...
}

@media(max-width:659px){
...
}

Correct media queries should look like this:

@media screen and (max-width: 1199px) {
...
}

@media screen and (max-width: 659px) {
...
}

Quick Instruction for Working on the Issue ‼️ Before checking out to a new branch, ensure you have the latest updates from the main by running git pull command.

This pull request resolves [#123](https://github.com/username/repository/issues/123)
github-actions[bot] commented 6 months ago

@NazarPauk 👋

Thanks for dropping in with the issue! Our team is ready to dive into it as soon as possible! 🚀

If you would like to work on this issue, please wait for us to decide if it's ready; hang tight until we've given it the green light. The issue will be ready to work on once we remove the Needs triage label.

To claim an issue that does not have the Needs triage label, please leave a comment that says ".take". If you have any questions, please follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

Let's make some magic together! ✨

MarPostovik commented 6 months ago

Hi @NazarPauk Good job on writing your fisrt issue! 👍 I have a few suggestions on how to improve it:

NazarPauk commented 6 months ago

Done, thank you for the suggestion!

MarPostovik commented 6 months ago

@NazarPauk thank you for your changes. But let's also point out in the instruction that the person will need to test if the updated media queries are still working. Hint: take a look at other issues in our project to find out where and how to write this part.

naumch1k commented 6 months ago

Hey @NazarPauk 👋 Let's also make a minor formatting adjustment to CSS code examples to make them more precise and consistent. Please replace 'html' with 'CSS' after the triple backticks (```) to indicate that code blocks contain CSS styling. This adjustment will bring some familiar CSS styling to your code snippets, making them easier to read and work with

NazarPauk commented 6 months ago

@naumch1k hey! indicated, thank you for the suggestion

wwily commented 5 months ago

.take

github-actions[bot] commented 5 months ago

@wwily 👋 Thanks for picking up this issue! 🙌 Feel free to reach out if you need any help or have questions!