search

p-foundation / pink-app

The repository is created for learning adaptive web design and team collaboration through git and GitHub
https://p-foundation.github.io/pink-app/
0 stars 0 forks source link

fix: ensures accessibility tags match pages language #51

Closed NazarPauk closed 5 months ago

NazarPauk commented 5 months ago

Description

Branch created: fix-accessibility-tag, code checked for accessibility tags in English and changed to Russian, tested using developer tools.

Task Link

This pull request resolves https://github.com/p-foundation/pink-app/issues/45

Changes Made

Changed accessibility tags such as aria-label, title, and span descriptions of elements with SVG icons hidden using the visually-hidden class from English to Russian on the Index, form, components pages:

From <span class="visually-hidden">Twitter logo</span> to <span class="visually-hidden">Логотип Twitter</span> From aria-label="First review" to aria-label="Первый отзыв" From <title>Pink App</title> to <title>Pink: Приложение</title> From <html lang="en"> to <html lang="ru"> From alt="Логотип айфон" to alt="Логотип Apple"

Checklist

Before submitting this pull request, please ensure the following:

naumch1k commented 5 months ago

Hey, @NazarPauk, thank you for addressing my comments! Would you please take care of the conflicts so I can complete the merge?