The previous check was checking if the enums returned by getopt were non-zero, which they always are, regardless of whether the option has been specified or not.
Fixes: e7d1c91 ("server: Check SHELL only when neither --sh nor --csh is specified") from #438
coverage: 69.533% (-0.007%) from 69.54%
when pulling 31ce070c297753f576d0d1e76c69ac9ba91c6763 on alanc:shell
into a8b94642dbe6d52aa7a7805fbb60b64c4cfd7245 on p11-glue:master.
The previous check was checking if the enums returned by getopt were non-zero, which they always are, regardless of whether the option has been specified or not.
Fixes: e7d1c91 ("server: Check SHELL only when neither --sh nor --csh is specified") from #438