pachico / slim-swoole

Convenient library to run SlimPHP applications with Swoole
https://github.com/pachico/slim-swoole/
MIT License
95 stars 12 forks source link

For cookies, use cookie method instead of header method #14

Closed imefisto closed 4 years ago

imefisto commented 5 years ago

Description

fixes #13

How has this been tested?

You can reproduce the issue with this code:

<?php

define('PORT', 9502);

$http = new swoole_http_server("127.0.0.1", PORT);

$http->on("start", function ($server) {
    echo "Swoole http server is started at http://127.0.0.1:" . PORT . "\n";
});

$http->on("request", function ($request, $response) {
    $response->cookie("TestCookie1", "swoole1");
    $response->cookie("TestCookie2", "swoole2");
    $response->cookie("TestCookie3", "swoole3");
    $response->end();
});

$http->start();

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

If you're unsure about any of these, don't hesitate to ask. We're here to help!