search

pachocanadian / sole

SOLE - Simulator Of Lifts and Elevators
GNU General Public License v3.0
1 stars 0 forks source link

Add load() and unload() methods to BasePerson #13

Closed Stemist closed 5 years ago

Stemist commented 5 years ago

BaseElevator calls its own unload(self) method

def unload(self): carrying = self.get("carrying") if(type(carrying) == list): for p in carrying: p.unload()

It looks like BasePerson will need its own load() and unload() methods as "p.unload()" is calling a method belonging to a person object in the carrying list that doesn't exist.

Stemist commented 5 years ago

I was wondering if it makes slightly more intuitive sense for the elevator to "unload" itself rather than a person to unload themselves.

pachocanadian commented 5 years ago

If so then it's the same argument with floors.

If an elevator unloads, are they then inspecting each person to see who gets unloaded?

I don't really care either way, put some functional code in place and we'll see how it pans out.

On Wed., Aug. 21, 2019, 18:19 Stemist, notifications@github.com wrote:

I was wondering if it makes slightly more intuitive sense for the elevator to "unload" itself rather than a person to unload themselves.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pachocanadian/sole/issues/13?email_source=notifications&email_token=AJBVIOXPRAAPV4PIKDAK2GLQFXSSZA5CNFSM4IMWGUXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD43SK6Y#issuecomment-523707771, or mute the thread https://github.com/notifications/unsubscribe-auth/AJBVIOVSQDPIIIL5YJE2ZJ3QFXSSZANCNFSM4IMWGUXA .