pachterlab / sleuth

Differential analysis of RNA-Seq
http://pachterlab.github.io/sleuth
GNU General Public License v3.0
305 stars 94 forks source link

fix double-negation in gene_column check upon manual change of pval_aggregate in sleuth_object #240

Open dlaehnemann opened 4 years ago

dlaehnemann commented 4 years ago

The changed code would previously stop with an error, if you assigned the value TRUE to pval_aggregate in a sleuth object with the gene_column defined, contrary to the error message given. @AntonieV and I stumbled upon this, and believe this is merely an unintended double-negation in the if-clause.

dlaehnemann commented 4 years ago

Just a quick ping @warrenmcg @pimentel, in case this PR slipped by.