search

pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr
MIT License
13 stars 6 forks source link

Remove `hake::` when not needed, as it will use library version not the local version; need to keep some though. #1079

Closed andrew-edwards closed 10 months ago

cgrandin commented 11 months ago

Keep the ones in vignettes and documentation/comments

andrew-edwards commented 10 months ago

Presumably good to remove them in the YAML?

output:
 hake::hake_pdf:

Else R will use the library version of hake_pdf().

andrew-edwards commented 10 months ago

Also see 759aec7e and 3fa8e733. Kept hake:: in output that was a message from the user, and kept it in all vignettes and other comments. doc builds okay, haven't tested the talks. Closing as seems done, feel free to re-open if not.

cgrandin commented 10 months ago

Presumably good to remove them in the YAML?

output: hake::hake_pdf:

Not sure now, I will test everything to make sure it all renders on the server

andrew-edwards commented 10 months ago

render() works fine, and never had hake:: in it. Think you edited your comment as I was thinking about it!

cgrandin commented 10 months ago

Did you restart R, then clean(), then render()

Also try the beamer presentations

andrew-edwards commented 10 months ago

Yes to first. Haven't tried any beamer ones at all yet this year.