search

pacific-hake / hake-assessment

:zap: :fish: Build the assessment document using latex and knitr
MIT License
13 stars 6 forks source link

Parameter comparison table (base model; 2023 base model) 2024 relative SSB row incorrect #1139

Closed aaronmberger-nwfsc closed 8 months ago

aaronmberger-nwfsc commented 8 months ago

Parameter comparison table between current assessment and last year's assessment includes a relative spawning biomass in 2024 row, but the code must take the end_yr for the specific assessment because the 2023 base model column is showing relative SSB for 2023, whereas the Base model is showing relative SSB for 2024.

The fishing intensity is probably wrong too because the 2023 assessment model wouldn't be reporting that for 2023.

Perhaps we just show end_yr-1 for the current year and end-yr for last year, with the row column name being 2023 relative SSB

image

aaronmberger-nwfsc commented 8 months ago

Or the 2024 relative SSB row and the 2023 relative fishing intensity row could just say 'terminal year relative spawning biomass' and 'terminal year fishing intensity', though that could get confusing too.

andrew-edwards commented 8 months ago

Should be dashes like we had last year. I thought this was the one that Chris might have had to hard-wire some of the values, but then he did get the 2023 assessment .rds file in the same format as the 2024 assessment one. I think that 'terminal year relative spawning biomass' gets confusing, and comparing, say, 2023 fishing intensity for one assessment with 2022 intensity for another assessment isn't really meaningful (and pretty confusing!).