search

pacificclimate / climate-explorer-data-prep

0 stars 0 forks source link

Issue/118 Refactor `decompose_flow_vectors` for further WPS processes #122

Closed sum1lim closed 4 years ago

sum1lim commented 4 years ago

This PR resolves #118

For a better utility of the program, main function has been created and wraps the functionality of decompose_flow_vectors. The script and main function will be imported into other programs, thus the scripts package should be included in ce_dataprep. In ordered to do that __init__.py has been created.

corviday commented 4 years ago

This script was excluded from CI testing because the way it was written made it difficult for the test system to call. That issue should be fixable now, but I'm not sure if we'd rather make it part of this PR, or do it separately.

rod-glover commented 4 years ago

Thanks, @corviday for providing the ground-truth check.

sum1lim commented 4 years ago

@corviday It is really interesting to see the actual output illustrated on a real map and glad to see the outputs are correct. Thank you! I guess this PR is ready to be merged, so I will do it right away. Thanks to all who made comments!