search

packbackbooks / lti-1-3-php-library

A library used for building IMS-certified LTI 1.3 tool providers in PHP.
Apache License 2.0
39 stars 25 forks source link

DeepLinkResource iframe - need for src parameter? #108

Closed cmcfadden closed 1 year ago

cmcfadden commented 1 year ago

Thanks for all your work on this, it's a great project. My read of the deep linking spec implies that the LtiDeepLinkResourceIframe should have a src parameter, which is used to reference the actual target for the iframe. It seems like Canvas won't render an iframe if that's not present. I'm happy to throw up a PR, but I wanted to check if that seems like the right interpretation first?

dbhynds commented 1 year ago

I agree with your assessment. Open a PR and assign me to it. I'll take a look quickly.