packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 48 forks source link

retest-failed triggers also successful test runs #1886

Open TomasTomecek opened 1 year ago

TomasTomecek commented 1 year ago

image

only 37 was failed, the comment triggered testing for 36 and rawhide as well

packit.yaml

specfile_path: ansible-bender.spec
actions:
  create-archive:
    - "python3 setup.py sdist --dist-dir ."
    - "sh -c 'echo ansible-bender-$(python3 setup.py --version).tar.gz'"
  get-current-version:
    - "python3 setup.py --version"
jobs:
- job: copr_build
  targets:
  - fedora-all
  trigger: pull_request
- job: tests
  trigger: pull_request
  targets:
  - fedora-all
- job: propose_downstream
  trigger: release
  dist_git_branches: [rawhide]
srpm_build_deps:
  - python3-pip # "python3 setup.py --version" needs it
  - python3-setuptools_scm
Venefilyn commented 1 year ago

Just encountered this as well in https://github.com/oamg/convert2rhel/pull/731

bocekm commented 1 year ago

FYI, there's a known workaround - go to the Checks tab of the PR and re-run the failed jobs manually one by one.

lbarcziova commented 1 year ago

This especially doesn't work when using identifiers, as we filter only targets and utilise the *_targets_override and do not consider the identifiers at all (encountered in https://github.com/neoave/mrack/pull/262)