search

pact-foundation / pact-ruby-standalone

A standalone pact command line executable using the ruby pact implementation and Travelling Ruby
https://pact.io
MIT License
42 stars 33 forks source link

unable to run application, when invoked from a path with & in a folder name #54

Open Igor-Pchelko opened 4 years ago

Igor-Pchelko commented 4 years ago

Pre issue-raising checklist

I have already:

Software versions

Expected behaviour

curl -LO https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.85.0/pact-1.85.0-osx.tar.gz
tar xzf pact-1.85.0-osx.tar.gz
cd pact/bin
./pact-mock-service --help start

./pact-mock-service --help start Should return help information.

Actual behaviour

./pact-mock-service --help start returns error. 

./pact-mock-service --help start

/Users/__removed__/_R&D/pact/pact/lib/ruby/bin/ruby: line 14: D/pact/pact/lib/ruby/lib/ruby/gems/2.2.0: No such file or directory
Igor-Pchelko commented 4 years ago

Looks like the issue is similar to the: https://github.com/pact-foundation/pact-ruby-standalone/issues/37

But in my case the base directory was __R&D. And self contained pact can't resolve the path on OSX with symbol &.

Igor-Pchelko commented 4 years ago

May be it's related to the issue with path on OSX: https://github.com/phusion/traveling-ruby/pull/94 ?

bethesque commented 4 years ago

Yes, the bug looks correct. I don't know how to get that change into our codebase however. We might have to do some dirty hacks. We're in the process of moving off the Travelling Ruby package however, and replacing it with a Rust shared library. Would you be able to use a different directory in the meantime?

Igor-Pchelko commented 4 years ago

Yep, sure.

TimothyJones commented 3 years ago

@bethesque - would this diff be the workaround we'd need?

https://github.com/expo/expo-cli/commit/920bb1a68abfca57f553693ea06b54b045d95ea6