search

pact-foundation / pact-ruby

Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project.
https://pact.io
MIT License
2.17k stars 216 forks source link

Failed verification of pending Pact fails provider test suite when other non-pending Pacts are successfully verified in the same suite #223

Closed ghost closed 4 years ago

ghost commented 4 years ago

Relevant versions

Steps to reproduce

Observed Issue

The provider test suite fails due to the failed verification of the pending pact. Caused by: https://github.com/pact-foundation/pact-ruby/blob/eb1a5893cd8670397cfa93dbd10d618f8f4b6d3c/lib/pact/provider/pact_spec_runner.rb#L162

Desired Behavior

The provider test suite only fails when non-pending (previously verified) pacts fail the verification test. Failed verification of pending pacts do not cause the provider test suite to fail.

bethesque commented 4 years ago

I had a good dig around today, and while I haven't got a fix yet, I have an idea of how to do it. Got to make sure it fails correctly for the non-pending pacts.