feat(CI): use setup-ruby's bundle installer and cache

pact-foundation / pact-ruby

Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project.

https://pact.io

MIT License

2.17k stars 216 forks source link

feat(CI): use setup-ruby's bundle installer and cache #275

Closed josephyi closed 2 years ago

josephyi commented 2 years ago

use setup-ruby to run bundle install
refactor BUNDLE_GEMFILE to the job level

Test runs with these changes can be observed here - https://github.com/josephyi/pact-ruby/actions/workflows/test.yml

bethesque commented 2 years ago

Why is the BUNDLE_GEMFILE: active-support.gemfile removed?

bethesque commented 2 years ago

Oh, I see! Sorry, was not reading properly.

bethesque commented 2 years ago

Thanks!

I only realised after I'd pressed the "merge" button, but this is a "chore" not a "feat". "feat" is only for things that affect the user and should be included in release notes.

josephyi commented 2 years ago

Thanks!

I only realised after I'd pressed the "merge" button, but this is a "chore" not a "feat". "feat" is only for things that affect the user and should be included in release notes.

Ooh sorry about that, makes sense!