feat(Link.put!): add a Link.put! method

[id-ilych]

The Link has get! and post! shorthand methods that do assert_success! on the result. This PR adds missing put! shorthand.

Should I also update these lines to use get!?

• https://github.com/pact-foundation/pact-ruby/blob/503cedbe9f7505c0be8ff10222967a96a5a9aa6d/lib/pact/pact_broker/fetch_pacts.rb#L75
• https://github.com/pact-foundation/pact-ruby/blob/503cedbe9f7505c0be8ff10222967a96a5a9aa6d/lib/pact/pact_broker/fetch_pacts.rb#L80
• https://github.com/pact-foundation/pact-ruby/blob/503cedbe9f7505c0be8ff10222967a96a5a9aa6d/lib/pact/pact_broker/fetch_pact_uris_for_verification.rb#L57

[bethesque]

Sure, thank you. Is the put ever used?

[id-ilych]

Hey @bethesque :wave:

Yes, it seems so:

• https://github.com/pact-foundation/pact-ruby/blob/503cedbe9f7505c0be8ff10222967a96a5a9aa6d/lib/pact/provider/verification_results/publish.rb#L85-L91
• https://github.com/pact-foundation/pact-ruby/blob/503cedbe9f7505c0be8ff10222967a96a5a9aa6d/lib/pact/provider/verification_results/publish.rb#L104-L107

[bethesque]

Just checking in on open PRs. I'm happy to merge this, but there's no point unless the method is actually called, so to make it worth merging, the places that call put.assert_success! should be updated at the same time.

[id-ilych]

Hey @bethesque :wave:

In the pact-ruby code base it is of no use, since both usages raise custom errors instead of the standard one.

But the method is used in our custom extension (formatter). Of course I can just monkey-patch it but not sure I understand why not to add banged version for put method when all the other methods have it already. At least for the sake of symmetry.

But if there is a policy to only have methods directly used in the repo, then ok, please close the PR in that case.

[bethesque]

If it's not used locally, it might get deleted. Just monkey patch the class, imo ;)