pact-foundation / pact_broker

Enables your consumer driven contracts workflow
http://pactflow.io
MIT License
708 stars 177 forks source link

Auto cleanup is not starting, missing cleanup.sh script in docker container #419

Closed filipcynarski closed 3 years ago

filipcynarski commented 3 years ago

Pre issue-raising checklist

I have already (please mark the applicable with an x):

Software versions

Expected behavior

An automated cleanup script should be invoked

Actual behavior

The automated cleanup script is not invoked even I follow instructions from the documentation.

I've found the cleanup.sh script which this code is using is not present on docker container

Steps to reproduce

Pass following variables to docker container:

PACT_BROKER_LOG_LEVEL: DEBUG PACT_BROKER_DATABASE_CLEAN_ENABLED: true PACT_BROKER_DATABASE_CLEAN_DELETION_LIMIT: 100000 PACT_BROKER_DATABASE_CLEAN_KEEP_VERSION_SELECTORS: '[{"max_age": 20}, { "latest": true, "tag": true}, { "tag": "master", "max_age": 50}]' PACT_BROKER_DATABASE_CLEAN_CRON_SCHEDULE: "45 13 *"

Relevant log files

Nothing appears in log even the corn file exists looks like the script does not exist and there is nothing to run.

bethesque commented 3 years ago

Can you double check the docker image version, as this is not right

pact-broker docker version: 7.9.1

Are you using the pactfoundation docker image or the dius one?

filipcynarski commented 3 years ago

Sorry my mistake I'm using pact broker from pactfoundation version 2.79.1

bethesque commented 3 years ago

I've fixed the path to the clean script and released 2.79.1.1

filipcynarski commented 3 years ago

awesome :) Thank you! @bethesque