search

padawan-php / padawan.vim

A vim plugin for padawan.php completion server
MIT License
79 stars 6 forks source link

2GB of memory isn't enough #27

Open TLyngeJ opened 7 years ago

TLyngeJ commented 7 years ago

I tried this plugin on a Drupal project and the generation of the index seems to fail, when PHP tried to allocate more than two GB of memory.

Didn't make much sense to begin with cause I've set the PHP memory limit to -1 in the CLI ini.

So I did a grep -R 'ini_set(' from the ~/.composer/vendor/mkusher folder and realised that the memory is fixed to two GB in padawan/bin/padawan.

Why is that, and would there be a way to increase it, without hacking the PHP component?

mkusher commented 7 years ago

hm, I can't say that this limit was set "on purpose", looks like it better to remove it from bin

mkusher commented 7 years ago

@TLyngeJ please, have a look https://github.com/padawan-php/padawan.php/pull/97

TLyngeJ commented 7 years ago

Yeah, I believe that should cut it.

memory_limit also set in the padawan-server, but I suppose that it's safe enough to assume that it wont go near that limit.

mkusher commented 7 years ago

@TLyngeJ well, I've merged fix to master, so it should work well now