search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

config: add password to database config #269

Closed grvcoelho closed 6 years ago

grvcoelho commented 6 years ago

Description

Add the database password to config/database. This will allow the application not to rely on credstash to get this sensitive information.

Remove the database password from lib/credentials and fix every place that called database.getModel or database.getDatabase.

This closes https://github.com/pagarme/ghostbusters/issues/12 (internal)

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed: