search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

docker: make Dockerfile ready for production #276

Closed evaporei closed 6 years ago

evaporei commented 6 years ago

Description

Make Dockerfile ready for production by following good practices that make sense for this project.

Some of them are here: https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md http://nodesource.com/blog/8-protips-to-start-killing-it-when-dockerizing-node-js/

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

this closes https://github.com/pagarme/ghostbusters/issues/30