search

pagarme / superbowleto

:football: A microservice to issue, register and manage boletos
MIT License
5 stars 0 forks source link

docker: divide production docker file in two #279

Closed evaporei closed 6 years ago

evaporei commented 6 years ago

Description

Now there are two dockerfiles for production, one for the server, and other for the worker, each one starting the container at src/bin/server.js or src/bin/worker.js.

Your checklist for this pull request

:rotating_light: Please review this items for a good pull request. :four_leaf_clover:

  1. I've read the project's Contributing Guidelines
  2. My commits are well written and follow pagarme/git-style-guide
  3. My changes are well covered by tests and logs
  4. I've updated the project docs (if needed)
  5. I fell safe about this implementation
  6. I feel comfortable with the code I wrote, and I'm not ashamed to show it to my friends

In a good pull request, everything above is true :relaxed:

this closes https://github.com/pagarme/ghostbusters/issues/149

claytonsilva commented 6 years ago

@otaviopace nessa pr voce ainda nao vai adaptar o projeto para a nova infra não né?

evaporei commented 6 years ago

O objetivo desse PR é simplesmente criar dois Dockerfiles, um para o worker e outro para o server, como é descrito na issue: https://github.com/pagarme/ghostbusters/issues/149 :)

claytonsilva commented 6 years ago

show então to revisando aqui

evaporei commented 6 years ago

@grvcoelho gostei da ideia, já que o tldr é open source como o superbowleto, acho válido mantermos um padrão cross-project. Já ajustei conforme a sugestão :)