pagefaultgames / pokerogue

A browser based Pokémon fangame heavily inspired by the roguelite genre.
https://pokerogue.net
GNU Affero General Public License v3.0
4.3k stars 1.71k forks source link

[BUG] Multi Hit - Multi target moves not working if... #1558

Closed hightowernl closed 1 month ago

hightowernl commented 3 months ago

Describe the bug So I got thrown into a double battle, my Darkrai knows Fiery Wrath which hits both targets. It holds 3x multiple hit lenses so every time it attacks those attacks will hit 4 times. 1 of the opponent used Fly, Fiery Wrath missed that target, then only hit the other opponent 1x and then stopped. I think it should hit the other opponent 4x as that Pokemon wasn't using Fly/Dig or anything.

To Reproduce

  1. Have a Pokemon hold at least 1 lens to hit multiple times
  2. Get into a double battle
  3. Pray 1 of the opposing Pokemon knows Fly/Dig/anything that would make your attack miss, and that they move first.
  4. Use a move that hits both opponents.

Expected behavior

Miss the flying opponent and hit the other multiple times.

Screenshots / Videos

Device

PC

Additional context

hayuna commented 3 months ago

@hightowernl I've added recording how it looks like to bugfix would be addressed faster.

To the author: If something is wrong in my example, please comment it.

Link to demo

Smewkie commented 3 months ago

Can confirm this is also the behavior if you have a move that hits both pokemon and is less than 100% accuracy + multilens, hitting one pokemon but missing the other will result in the extra hits that should go to the pokemon you did hit to just not happen.

innerthunder commented 1 month ago

Fixed by https://github.com/pagefaultgames/pokerogue/pull/2648