search

paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine
MIT License
126 stars 97 forks source link

Fix scroll on click #19

Closed ZaLiTHkA closed 8 years ago

ZaLiTHkA commented 8 years ago

As per my comment in paginagmbh/redmine_lightbox2#18, this PR implements the helpers option to lock content in place and prevent page scrolling when a FancyBox popup is activated. See the docs for more information.

I've also bumped the version for a dev snapshot, I'll leave it up to you (@tofi86) to confirm and release it in your own way. :)

So far, this has only been tested and confirmed working in Redmine 2.6.6.

tofi86 commented 8 years ago

PR is waiting for details in #18

ZaLiTHkA commented 8 years ago

As per this comment, the point of this pull request doesnt really seem valid anymore. I'll work out what I did wrong in my theme and fix it there, definitely not an issue with this plugin. :)