search

paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine
MIT License
126 stars 97 forks source link

Thumbnails are displayed even though display thumbnails is off in redmine settings #29

Open jdkemme opened 8 years ago

jdkemme commented 8 years ago

Redmine 3.3

setting

thumbnail

tofi86 commented 8 years ago

Is this a new 3.3 setting? never noticed this before...

Anyways, you're right, this setting should be taken into account...

jdkemme commented 8 years ago

This doesnt appear to be a new setting in 3.3. The behavior of the setting in redmine, when enabled, displays an image thumbnail preview. When the setting is unchecked, it removes the preview entirely.

Lightbox behavior honors this setting- when checked it displays the image at the thumbnail size. However when unchecked, unlike core redmine, it displays the image at hard coded width => '180' in _links.html.erb in the 'else' condition. To mimic core redmine behavior, the else condition that adds <div class='images'> should be removed, or at least made optional via a setting.

tofi86 commented 8 years ago

Oh, yeah, you're right... This has been the behaviour ever since I took over the redmine_lightbox project and forked it to redmine_lightbox2.

While I agree with you that this setting should be taken into account, the current behaviour is still a great solution for those who cannot use imagemagik/rmagick on their system on which the thumbnail function depends...

Will think about that for the next release...