paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine
MIT License
126 stars 96 forks source link

Small issue with Redmine 3.4 #38

Closed Atmis closed 7 years ago

Atmis commented 7 years ago

Hello,

I noticed a small defect with Redmine 3.4 which introduced a change in the file preview (http://www.redmine.org/issues/25988)

In the history messages :

screenshot 2017-07-10 23_54_04 pma

If you click on the file link, you get an error message :

screenshot 2017-07-10 23_55_42 pma

But if you click on the thumbnail, then the picture shows normally.

Thanks again for this great plugin

tofi86 commented 7 years ago

Thanks, I will take a look in the next few days...

tofi86 commented 7 years ago

Thanks for reporting this. I pushed a couple of changes and fixes to the master branch but didn't release the new version 0.4.0 officially yet as I'm waiting for another fix with #37

The attachment list now looks like this in 3.4:

bildschirmfoto 2017-07-28 um 16 28 05

The journal details like this:

bildschirmfoto 2017-07-28 um 16 28 26


Stay tuned for official release of version 0.4.0 soon!

tofi86 commented 7 years ago

Screw it, not waiting for the other issue as I think it's not my fault anyway... ;-)

Version 0.4.0 for Redmine 3.4 has officially been released now... 🎉

Atmis commented 7 years ago

Thanks a lot ! After a quick test, I confirm it works as expected :-)

tofi86 commented 7 years ago

Thanks! 👍